Repository navigation
cleanup(internal/sidekick/rust): remove extend_grpc_transport option - #7962
Merged
dbolduc merged 2 commits intoNov 19, 2026
Merged
Conversation
Make the inner gRPC client field in the grpc-client transport template unconditionally visible within the generated crate and remove the extend_grpc_transport module configuration option along with its corresponding extend-grpc-transport codec flag. Generated grpc-client transport modules are already internal to the crate, so restricting the inner gRPC client field to private visibility unless an opt-in flag was set added unnecessary configuration overhead for veneer crates that extend generated transports.
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the extend_grpc_transport configuration option and all of its associated implementation, tests, and documentation across the codebase. Consequently, the inner field of the generated Rust gRPC client transport struct is now always defined with pub(crate) visibility. I have no additional feedback to provide as there are no review comments.
dbolduc
marked this pull request as ready for review
November 19, 2026 22:46
haphungw
approved these changes
Nov 19, 2026
Signed-off-by: Darren Bolduc <dbolduc@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unconditionally make the transport stub
pub(crate)in gRPC-based crates so it can be extended in veneers.